Bring back Playwright-Electron Workbench's on-failure screenshot + new PLAYWRIGHT_RECORD_VIDEO #5464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5464 +/- ##
==========================================
- Coverage 86.04% 86.02% -0.03%
==========================================
Files 95 95
Lines 35754 35754
==========================================
- Hits 30766 30757 -9
- Misses 4988 4997 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Took a million years but CI is green now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The on-failure screenshot was broken in the Playwright-Electron's Workbench. After an f-ton of looking (2.5 days) at Playwright source code I've been able to restore this, but unfortunately the Timeline is still broken. While I believe I have an idea of why the Timeline is still broken, I don't advise myself to continue to use cycles on this problem.
As an alternative, I've devised a way for users to be able to record videos on particular tests if they wish, with a new envvar called PLAYWRIGHT_RECORD_VIDEO. Set it to anything, and it will record videos into Playwright's snapshot directory. Only use this for a narrow set of tests.
Because this is somewhat still broken I'm not going to document this - we are still going to push for people to use the
chrome:testwhen needing to debug further.