git: fix "git clean" invocation for submodule #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command passed after a "git submodule foreach" should be invoked as a single string, as it is on line 416 of this file. Otherwise "-x" is treated as an argument to "foreach" and it errors. See golang/dep#2176 for more details.
|
✅ Build vcs build-141.master completed (commit 3cc1fb67e9 by @kevinburke) |
|
@mattfarina It looks like this bug cropped up with the release of git 2.22.0. Is this something you'd consider merging and updating glide with? Thank you! |
|
The failed tests are due to an unrelated issue fixed elsewhere. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command passed after a "git submodule foreach" should be invoked
as a single string, as it is on line 416 of this file. Otherwise "-x"
is treated as an argument to "foreach" and it errors. See
golang/dep#2176 for more details.