cleanup code in tile iterator example #2111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 13, 2025 17:33
Signed-off-by: Mayank Mishra <[email protected]>
Signed-off-by: Mayank Mishra <[email protected]>
hwu36
reviewed
Feb 19, 2025
|
|
||
| for(; iterations > 1; --iterations) { | ||
|
|
||
| for(; iterations > 0; --iterations) { |
There was a problem hiding this comment.
we still need to keep the initialization part of code. we want fragment is in a known state before the load and store operation.
There was a problem hiding this comment.
hmm, any reason for that?
logically it doesnt make sense to me but I could also be wrong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as title suggests