Rework login-flow to retrieve user object from appinfo #9499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bijij
commented
Jul 16, 2023
| @@ -610,8 +610,8 @@ async def login(self, token: str) -> None: | |||
| token = token.strip() | |||
|
|
|||
| data = await self.http.static_login(token) | |||
| self._connection.user = ClientUser(state=self._connection, data=data) | |||
| self._application = await self.application_info() | |||
| self._connection.user = ClientUser(state=self._connection, data=data['bot']) # type: ignore | |||
There was a problem hiding this comment.
Not sure if it would be better to raise above here if 'bot' not in data.
I don't think it can ever happen though.
|
Do we want add support for the new PATCH endpoint for applications? |
|
Sure. |
|
Seems the branch in the API docs has been merged. Given last week I checked and it didn't have the fields, I'm guessing that it's not happening. |
|
Yeah, they basically said to make an issue if we want it but my experience with that means that it's never happening. |
Rapptz
force-pushed
the
master
branch
2 times, most recently
from
3717ed6 to
8953938
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR reworks login flow to use the new
botkey in the application payload for the ClientUser object, rather than making a 2nd HTTP request.Note: in its current form, the user object provided by discord by this endpoint lacks information previously used in the
ClientUserobject, this PR should only be accepted if discord commits to adding the missing information.Information currently lacking:
localemfa_enabledverifiedChecklist