Add svelte options tag to fix rendering in Svelte 5 #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for the issue and the PR! much appreciated 😄 Would you be able to run |
|
Sorry about that, have just pushed it. |
|
no worries! did a quick check on the repl as well and thankfully the order of svelte: options doesn't matter (didn't think it would) so hopefully should work in svelte 5 even though I haven't quite managed to get svelte 5 in this project yet I'll close the issue when it's released too 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Svelte 5 appears to require the addition of
<svelte:options namespace='svg'/>inIcon.sveltein order to render the SVG.Related issue: #1059
This pull request can be reviewed on