Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade dependencies in preparation for svelte 5 #1165

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

benmccann
Copy link
Contributor

Minimum versions of a number of different Svelte packages must be used in order to support Svelte 5

@RobBrazier
Copy link
Owner

apologies for the delay on getting to this, thanks for the PR! I'll be honest I haven't kept up with svelte lately

the sveltekit dependencies are mainly for the demo site really - there aren't any production dependencies as I was just using stuff from vanilla svelte (and that was a peer dependency anyway)

Good to update nonetheless, I haven't tested with svelte 5 yet to see whether it actually doesn't work though

@benmccann
Copy link
Contributor Author

Svelte 5 can work with components written in Svelte 4 syntax and I've been using this library in that fashion for a long time. I'd like to send a PR to upgrade this library to Svelte 5 runes syntax once the final release of Svelte 5 is out. This is something that would be required for that. I thought I'd send this piece of it now to break things up and make that PR a bit smaller. This PR should work just fine with Svelte 4 in the meantime

@RobBrazier RobBrazier merged commit 85ee99e into RobBrazier:master Sep 9, 2024
5 checks passed
@benmccann benmccann deleted the upgrade-deps branch September 9, 2024 18:05
@RobBrazier
Copy link
Owner

I was testing with svelte 5 and currently I can't install due to the peerDependencies not including v5 (it does work though when using local folders)
unsure if there's something 'special' with pre-release/next versions, but with version 3.3.3 even having a lower and upper bounds >= 3.43.1 < 6 it can't install currently

it works fine with that peerDependencies value on svelte 4, but I've had issues with peerDependencies before so am just going to leave it as-is for now 😓

@benmccann
Copy link
Contributor Author

You can normally ignore the peer dependency warnings, which is what I've been doing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants