Add check in Extrude(), replace replace codecvt_utf8_utf16 #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the outer loop of the shape is not closed
- enable polylines as mesh for IFCGRID, IFCGRIDAXIS - add bounds checks in TriangulateRevolution
make scaling by _geometryLoader.GetLinearScalingFactor() optional in GetFlatMesh. Alternative would be: make IfcGeometryProcessor::AddComposedMeshToFlatMesh public
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Extrude(): check if first point is equal to last point, otherwise the outer loop of the shape is not closed
In string_parsing.cpp, replace codecvt_utf8_utf16 which is deprecated in C++17