Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide Typings for Cone #276

Closed
2 of 19 tasks
hirako2000 opened this issue Jul 4, 2017 · 1 comment
Closed
2 of 19 tasks

Provide Typings for Cone #276

hirako2000 opened this issue Jul 4, 2017 · 1 comment
Assignees
@hirako2000 @ChaseWhite3

Comments

@hirako2000
Copy link
Collaborator

hirako2000 commented Jul 4, 2017 •
edited
Loading

Add types for the Cone mesh component. And improve/complete Box and Sphere

Version:
  • v2.x.x
  • v1.x.x
Issue type:
  • Bug
  • Proposal/Enhancement
  • Question
  • Discussion
Tested on:
Desktop
  • Chrome
  • Chrome Canary
  • Chrome dev-channel
  • Firefox
  • Opera
  • Microsoft IE
  • Microsoft Edge
Android
  • Chrome
  • Firefox
  • Opera
IOS
  • Chrome
  • Firefox
  • Opera
hirako2000 added a commit that referenced this issue Jul 4, 2017
@hirako2000
Completes Box/Sphere definition - Adds buffer flag to MeshComponentPa…
7a842e4 
…rams - removes unused material import #276
ChaseWhite3 pushed a commit that referenced this issue Jul 4, 2017
Complete Cone definition - #276
b26a9b7
ChaseWhite3 pushed a commit that referenced this issue Jul 4, 2017
Added Definition for Cone - #276
c1c78a0
ChaseWhite3 pushed a commit that referenced this issue Jul 4, 2017
Correcting openEnded type - naming convention for Params - #276
23f09f0
hirako2000 added a commit that referenced this issue Jul 4, 2017
@hirako2000
Fixes return type of Sphere and Box - #276
b1c568d
hirako2000 added a commit that referenced this issue Jul 4, 2017
@hirako2000
Adds description to Cone params, build/buildGeometry - #276
af1d78c
hirako2000 added a commit that referenced this issue Jul 4, 2017
@hirako2000
Improves Component and MeshComponent types doc #276
e9a4993
hirako2000 added a commit that referenced this issue Jul 5, 2017
@hirako2000
Merge pull request #277 from WhitestormJS/#276
ca241cb 
PR for #276
@hirako2000
Copy link
Collaborator Author

continued with #278

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hirako2000 hirako2000

@ChaseWhite3 ChaseWhite3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hirako2000 @ChaseWhite3