Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PerformanceModule #300

Closed
6 of 22 tasks
sasha240100 opened this issue Jul 16, 2017 · 0 comments
Closed
6 of 22 tasks

PerformanceModule #300

sasha240100 opened this issue Jul 16, 2017 · 0 comments
Assignees
@sasha240100
Labels
ENHANCEMENT MODULE
Milestone
v2.1.6

Comments

@sasha240100
Copy link
Member

sasha240100 commented Jul 16, 2017 •
edited
Loading

A concept of PerformanceModule:

Used in The last dinosaur

const app = new WHS.App([
  // ...
  new WHS.RenderingModule(),
  new PerformanceModule({
    dof: 50 // minimum fps.
  })
]);

const perf = app.use('performance');

perf.on('dof', enabled => {
  dofPass.enabled = enabled;
});
  • Turns off pass if lower than it's described minimum.
  • Support for multiple settings.
    • Only disables one-by-one
Version:
  • v2.x.x
  • v1.x.x
Issue type:
  • Bug
  • Proposal/Enhancement
  • Question
  • Discussion
Tested on:
Desktop
  • Chrome
  • Chrome Canary
  • Chrome dev-channel
  • Firefox
  • Opera
  • Microsoft IE
  • Microsoft Edge
Android
  • Chrome
  • Firefox
  • Opera
IOS
  • Chrome
  • Firefox
  • Opera
@sasha240100 sasha240100 self-assigned this Jul 16, 2017
@sasha240100 sasha240100 modified the milestone: v2.1.6 Jul 16, 2017
@sasha240100 sasha240100 mentioned this issue Jul 16, 2017
Merged
sasha240100 added a commit that referenced this issue Jul 17, 2017
@sasha240100
Merge pull request #301 from WhitestormJS/#300
fbe703f 
PerformanceModule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sasha240100 sasha240100

Labels
ENHANCEMENT MODULE
Projects
None yet
Milestone
v2.1.6
Development

No branches or pull requests
1 participant
@sasha240100