Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postprocessing and redux deps are missing #305

Closed
2 of 19 tasks
hirako2000 opened this issue Jul 17, 2017 · 3 comments
Closed
2 of 19 tasks

postprocessing and redux deps are missing #305

hirako2000 opened this issue Jul 17, 2017 · 3 comments
Assignees
@hirako2000
Labels
FIXME MODULE
Milestone
v2.1.6

Comments

@hirako2000
Copy link
Collaborator

hirako2000 commented Jul 17, 2017 •
edited
Loading

postprocessing is used by the postprocessing module, but is not declared in deps.
redux is now used to keep the store, but also is not declared in deps.

They should not be in devDependency, but in dependency.

Version:
  • v2.x.x
  • v1.x.x
Issue type:
  • Bug
  • Proposal/Enhancement
  • Question
  • Discussion
Tested on:
Desktop
  • Chrome
  • Chrome Canary
  • Chrome dev-channel
  • Firefox
  • Opera
  • Microsoft IE
  • Microsoft Edge
Android
  • Chrome
  • Firefox
  • Opera
IOS
  • Chrome
  • Firefox
  • Opera
@hirako2000 hirako2000 changed the title postprocessing dep is missing postprocessing and reduxdeps are missing Jul 17, 2017
@hirako2000 hirako2000 changed the title postprocessing and reduxdeps are missing postprocessing and redux deps are missing Jul 17, 2017
@hirako2000 hirako2000 self-assigned this Jul 18, 2017
hirako2000 added a commit that referenced this issue Jul 18, 2017
@hirako2000
Moves redux and postprocessing lib to dependencies - #305
02c9c78
@sasha240100
Copy link
Member

@hirako2000 you fix?

@hirako2000
Copy link
Collaborator Author

yea should be fixed. merge the PR.

sasha240100 added a commit that referenced this issue Jul 18, 2017
@sasha240100
Merge pull request #306 from WhitestormJS/#305
4ad541a 
PR for #305
@sasha240100 sasha240100 modified the milestone: v2.1.6 Jul 18, 2017
@sasha240100
Copy link
Member

@hirako2000 merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hirako2000 hirako2000

Labels
FIXME MODULE
Projects
None yet
Milestone
v2.1.6
Development

No branches or pull requests
2 participants
@hirako2000 @sasha240100