Patch#2: DefineModule, StateModule #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hirako2000
reviewed
Jun 24, 2017
README.md
Outdated
| @@ -77,7 +77,7 @@ You can find lots of examples at [showcases](https://whs-dev.surge.sh/examples/) | |||
| const app = new WHS.App([ | |||
| new WHS.ElementModule(), // attach to DOM | |||
| new WHS.SceneModule(), // creates THREE.Scene instance | |||
| new WHS.CameraModule(), // creates PerspectiveCamera instance | |||
| new WHS.DefineModule('camera', new WHS.PerspectiveCamera()), // creates PerspectiveCamera instance | |||
There was a problem hiding this comment.
we have to be careful with updating readme, (well doc too if we publish early) as this module is not available with beta releases yet.
hirako2000
reviewed
Jun 24, 2017
| @@ -3,14 +3,14 @@ import * as UTILS from '../../globals'; | |||
| const ad = UTILS.appDefaults; | |||
There was a problem hiding this comment.
this example was broken btw. not sure perhaps we should remove it, the area light from three.js is an odd one.
hirako2000
reviewed
Jun 24, 2017
package.json
Outdated
| @@ -31,6 +31,7 @@ | |||
| "license": "MIT", | |||
| "homepage": "https://github.com/WhitestormJS/whitestorm.js#readme", | |||
| "dependencies": { | |||
| "@types/node": "^7.0.32", | |||
hirako2000
reviewed
Jun 24, 2017
| @@ -16,8 +16,8 @@ test('SceneModule', () => { | |||
| modules.scene = new WHS.SceneModule(); | |||
| }); | |||
|
|
|||
| test('CameraModule', () => { | |||
| modules.camera = new WHS.CameraModule(); | |||
| test('DefineModule', () => { | |||
There was a problem hiding this comment.
when we modify classes, I think we should try to add proper tests/assertions.
Maybe just check that data was populated with the passed in param (PerspectiveCamera), with the passed name?
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not yet complete and please do not merge it yet.
Patch includes:
DefineModule- replaces modules asCameraModulecamera: {}andlight: {}.StateModuleElementModulenew ElementModule(domObject)ModuleManagermanager.requiremanager.requirewhitestorm.js->whs.jsCircle&Coneadded