Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS: remove redundant file docblocks #136

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Mar 22, 2021

Context

  • Code style consistency

Summary

This PR can be summarized in the following changelog entry:

  • Code style consistency

Relevant technical choices:

  • No functional changes.
  • Code style compliance.

In YoastCS, namespaced files do not require a docblock and it is recommended not to have one.

This commit fixes this for all namespaced files in the Duplicate Post plugin.

Includes:

  • Moving the functionality description from the file docblock to the class docblock if it was more descriptive than the description given in the class docblock.
  • Moving any other relevant tags, like @since from the file docblock to the class docblock.
  • Removing redundant @package tags in class docblock.

Test instructions

This PR can be tested by following these steps:

  • N/A
    This is a code-only change and should have no effect on the functionality. If the build passes (linting, test runs), we're good.

In YoastCS, namespaced files do not require a docblock and it is recommended not to have one.

This commit fixes this for all namespaced files in the Duplicate Post plugin.

Includes:
* Moving the functionality description from the file docblock to the class docblock if it was more descriptive than the description given in the class docblock.
* Moving any other relevant tags, like `@since` from the file docblock to the class docblock.
* Removing redundant `@package` tags in class docblock.
@jrfnl jrfnl added this to the 4.2 milestone Mar 22, 2021
@jrfnl jrfnl merged commit 5fe0800 into develop Mar 22, 2021
@jrfnl jrfnl deleted the JRF/CS/remove-redundant-file-docblocks branch March 22, 2021 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant