Clear existing meta data to fix rewrite and republish with non-unique meta keys #192
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
As mentioned in #190, when using the Rewrite & Republish feature data of non-unique meta keys is lost due to the use of
update_post_meta()
inPost_Duplicator::copy_post_meta_info()
.This is not an issue with the Clone feature because
duplicate_post_copy_post_meta_info()
is usingadd_post_meta()
. That's why this PR suggests to useadd_post_meta()
inPost_Duplicator::copy_post_meta_info()
too. But since the same method is also used byPost_Republisher::republish_post_meta()
we have to make sure that existing meta data is removed first.Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
How to reproduce the bug
test_field
) and different valuesTest the solution
test_field
) and different valuesTest instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Documentation
Quality assurance
Fixes #190.