Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS: various minor cleanup #217

Merged
merged 1 commit into from
Dec 6, 2021
Merged

CS: various minor cleanup #217

merged 1 commit into from
Dec 6, 2021

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Dec 6, 2021

Context

  • Code consistency

Summary

This PR can be summarized in the following changelog entry:

  • Code consistency

Relevant technical choices:

  • Use FQN function calls in namespaced files.
  • null must be the last type in a docblock type declaration.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • N/A If the build passes, we're good.

* Use FQN function calls in namespaced files.
* `null` must be the last type in a docblock type declaration.
@jrfnl jrfnl added this to the 4.4 milestone Dec 6, 2021
@jrfnl jrfnl merged commit 0545927 into trunk Dec 6, 2021
@jrfnl jrfnl deleted the JRF/CS/minor-cleanup branch December 6, 2021 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant