-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
small fixes to WPSEO_Admin::maybe_upgrade() #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was fixed recently, so no need to merge this pull. |
seripap
pushed a commit
to seripap/wordpress-seo
that referenced
this pull request
Nov 19, 2015
Initial commit added preprocessor for preparing text for page analysis
moorscode
pushed a commit
that referenced
this pull request
Feb 19, 2016
Applied all feedback from CR 1
moorscode
added a commit
that referenced
this pull request
Aug 29, 2016
Extended endpoint with type and arguments to be better implementable for different systems
afercia
pushed a commit
that referenced
this pull request
Sep 5, 2016
Extended endpoint with type and arguments to be better implementable for different systems
2 tasks
2 tasks
2 tasks
jrfnl
added a commit
that referenced
this pull request
Nov 9, 2022
... for now. I believe this may need to be fixed by changing the tests... Relevant errors: ``` 265) Yoast\WP\SEO\Tests\Unit\Generators\Schema\WebPage_Test::test_generate_with_provider with data set #0 (array(false), array(array('WebPage'), 'https://example.com/the-post/#webpage', 'https://example.com/the-post/', 'the-title', array('https://example.com/#website'), '2345-12-12 12:12:12', '2345-12-12 23:23:23', array('https://example.com/the-post/...dcrumb'), 'the-language', array(array('ReadAction', array('https://example.com/the-post/')))), 'There is no image, and breadc...abled.') Creation of dynamic property Mockery_90_Yoast_WP_SEO_Helpers_Schema_ID_Helper::$webpage_hash is deprecated /home/runner/work/wordpress-seo/wordpress-seo/tests/unit/generators/schema/webpage-test.php:118 /home/runner/work/wordpress-seo/wordpress-seo/vendor/yoast/phpunit-polyfills/src/TestCases/TestCasePHPUnitGte8.php:56 266) Yoast\WP\SEO\Tests\Unit\Generators\Schema\WebPage_Test::test_generate_with_provider with data set #1 (array(true), array(array('WebPage'), 'https://example.com/the-post/#webpage', 'https://example.com/the-post/', 'the-title', array('https://example.com/#website'), '2345-12-12 12:12:12', '2345-12-12 23:23:23', array('https://example.com/the-post/...dcrumb'), array('https://example.com/the-post/...yimage'), 'the-language', array(array('ReadAction', array('https://example.com/the-post/')))), 'There is an image, but breadc...abled.') Creation of dynamic property Mockery_90_Yoast_WP_SEO_Helpers_Schema_ID_Helper::$webpage_hash is deprecated /home/runner/work/wordpress-seo/wordpress-seo/tests/unit/generators/schema/webpage-test.php:118 /home/runner/work/wordpress-seo/wordpress-seo/vendor/yoast/phpunit-polyfills/src/TestCases/TestCasePHPUnitGte8.php:56 ```
jrfnl
added a commit
that referenced
this pull request
Nov 10, 2022
... for now. I believe this may need to be fixed by changing the tests... Relevant errors: ``` 265) Yoast\WP\SEO\Tests\Unit\Generators\Schema\WebPage_Test::test_generate_with_provider with data set #0 (array(false), array(array('WebPage'), 'https://example.com/the-post/#webpage', 'https://example.com/the-post/', 'the-title', array('https://example.com/#website'), '2345-12-12 12:12:12', '2345-12-12 23:23:23', array('https://example.com/the-post/...dcrumb'), 'the-language', array(array('ReadAction', array('https://example.com/the-post/')))), 'There is no image, and breadc...abled.') Creation of dynamic property Mockery_90_Yoast_WP_SEO_Helpers_Schema_ID_Helper::$webpage_hash is deprecated /home/runner/work/wordpress-seo/wordpress-seo/tests/unit/generators/schema/webpage-test.php:118 /home/runner/work/wordpress-seo/wordpress-seo/vendor/yoast/phpunit-polyfills/src/TestCases/TestCasePHPUnitGte8.php:56 266) Yoast\WP\SEO\Tests\Unit\Generators\Schema\WebPage_Test::test_generate_with_provider with data set #1 (array(true), array(array('WebPage'), 'https://example.com/the-post/#webpage', 'https://example.com/the-post/', 'the-title', array('https://example.com/#website'), '2345-12-12 12:12:12', '2345-12-12 23:23:23', array('https://example.com/the-post/...dcrumb'), array('https://example.com/the-post/...yimage'), 'the-language', array(array('ReadAction', array('https://example.com/the-post/')))), 'There is an image, but breadc...abled.') Creation of dynamic property Mockery_90_Yoast_WP_SEO_Helpers_Schema_ID_Helper::$webpage_hash is deprecated /home/runner/work/wordpress-seo/wordpress-seo/tests/unit/generators/schema/webpage-test.php:118 /home/runner/work/wordpress-seo/wordpress-seo/vendor/yoast/phpunit-polyfills/src/TestCases/TestCasePHPUnitGte8.php:56 ```
hansjovis
pushed a commit
that referenced
this pull request
Nov 21, 2022
Introduces a bunch of the documentation, ported and cut up in smaller sections
7 tasks
6 tasks
This was referenced Apr 25, 2023
Closed
11 tasks
vraja-pro
pushed a commit
that referenced
this pull request
Sep 20, 2023
Fix for resource_hints_plain_cleanup
11 tasks
9 tasks
11 tasks
2 tasks
2 tasks
2 tasks
3 tasks
pls78
pushed a commit
that referenced
this pull request
Sep 24, 2024
…n_shutdown Include pluggable functions in shutdown callback
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've encountered a situation when Network activating the plugin on a multisite would throw "Cannot unset string offsets in /wp-content/plugins/wordpress-seo/admin/class-admin.php line 440".
I don't know if this is because a weird server configuration, but, in the snippet below, $options was a string, the isset would return true even if $options was not an array, and the unset line was throwing the error mentioned earlier.
I took the liberty to apply some is_array() checks to those lines, example: