Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check for facebook_image post meta as primary Facebook thumbnail #5

Closed
wants to merge 1 commit into from

Conversation

ddn
Copy link

@ddn ddn commented Jan 15, 2013

On some sites, maintainers may desire to retain more control of what image is used for Facebook OpenGraph thumbnails.

My site, for example, uses a wide landscape format for site images. When Facebook pulls these images, it often crops them in an unfavorable way. I prefer to manually select the image I want promoted for the site content.

This change checks for a facebook_image post_meta value, and if it exists, returns it as the SOLE thumbnail for opengraph. Removing the return true would allow it to be returned as one of many if there are other thumbnails available.

Ideally, this would probably be an option that can be chosen in the setting.

@jdevalk
Copy link
Contributor

jdevalk commented May 14, 2013

Hi @ddn,

thanks for this! We're going to be far more active here on Github so we're actually looking properly into all these requests now. To be honest, we'll probably never add a "technical" fix like this. I want to do something like this but it'd require an actual interface in the plugin, where in the social meta box people could select an image... If you want to build a patch for that, that'd be most welcome :) if not, do let me know and I'll write up the issue and I'll assign it to a dev.

@barrykooij
Copy link
Contributor

I'm not expecting a new PR on this here, so I've created an issue #784.

@barrykooij barrykooij closed this Mar 13, 2014
@Amon001 Amon001 mentioned this pull request Jul 15, 2014
stodorovic pushed a commit to stodorovic/wordpress-seo that referenced this pull request Mar 10, 2016
@Rahe Rahe mentioned this pull request Apr 22, 2016
@Rabh013 Rabh013 mentioned this pull request Mar 21, 2020
@bloggian bloggian mentioned this pull request Apr 29, 2020
7 tasks
@sowon27 sowon27 mentioned this pull request Jul 28, 2020
9 tasks
omarreiss pushed a commit that referenced this pull request Feb 24, 2021
uses higher level function in yoast frontend class
@halimaurus halimaurus mentioned this pull request Apr 5, 2021
10 tasks
hansjovis pushed a commit that referenced this pull request Nov 21, 2022
hansjovis pushed a commit that referenced this pull request Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants