Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PC-291 Add reset buttons for indexable ignore lists #155

Merged
merged 6 commits into from
Jul 28, 2022
Merged

PC-291 Add reset buttons for indexable ignore lists #155

merged 6 commits into from
Jul 28, 2022

Conversation

KiOui
Copy link
Contributor

@KiOui KiOui commented Jul 21, 2022 •
edited by leonidasmi
Loading

NOTE: To be released together with PC-63

Summary

This PR can be summarized in the following changelog entry:

  • Add reset button for indexable ignore lists.

Relevant technical choices:

Milestone

  • I've attached the next release's milestone to this pull request.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Make sure both the Yoast SEO plugin (currently on this branch) and the Yoast Test Helper are active.
  • On the admin dashboard, go to Yoast SEO -> General.
  • Go to Indexables.
  • Ignore a couple of indexables.
  • Refresh the page, the indexables should not show up.
  • Now head over to Tools -> Yoast Test and click Reset Ignored indexables under Yoast SEO.
  • Go back to the indexables page and see that the indexables do show up again.

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

@KiOui KiOui added this to the 1.18 milestone Jul 21, 2022
@enricobattocchi enricobattocchi changed the title Add reset buttons for indexable ignore lists PC-291 Add reset buttons for indexable ignore lists Jul 25, 2022
@KiOui KiOui self-assigned this Jul 25, 2022
@leonidasmi
Copy link
Contributor

CR + Test: ✅

@leonidasmi leonidasmi merged commit bd8f270 into develop Jul 28, 2022
@leonidasmi leonidasmi deleted the PC-63-indexables-page branch July 28, 2022 06:32
@enricobattocchi enricobattocchi mentioned this pull request Mar 10, 2023
Merged
@enricobattocchi enricobattocchi added changelog: reverted Needs to be excluded from all categories in the changelog, should be used for reverted PR changelog: non-user-facing and removed changelog: other labels Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KiOui KiOui

Labels
changelog: non-user-facing changelog: reverted Needs to be excluded from all categories in the changelog, should be used for reverted PR
Projects
None yet
Milestone
1.18
Development

Successfully merging this pull request may close these issues.
3 participants
@KiOui @leonidasmi @enricobattocchi