Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to the newer key for the Local SEO version #198

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

enricobattocchi
Copy link
Member

@enricobattocchi enricobattocchi commented Sep 12, 2023

Summary

This PR can be summarized in the following changelog entry:

  • Fixes a bug where the DB version for Local SEO would not be updated correctly.

Relevant technical choices:

  • the key in wpseo_local storing the Local SEO version has changed from version to local_version since 12.3, but Test Helper was never adapted to reflect that.

Milestone

  • I've attached the next release's milestone to this pull request.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Install and activate Local SEO
  • Use Test Helper to change the DB version for Local SEO to a previous version e.g. 14.9
  • See that on reload the version is back to the actual one of the installed Local SEO (e.g. 15.0) because Local SEO has adjusted it.

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Fixes #

@enricobattocchi enricobattocchi added this to the 1.18 milestone Sep 12, 2023
@enricobattocchi enricobattocchi merged commit 8819c3b into release/1.18 Sep 13, 2023
@enricobattocchi enricobattocchi deleted the fix-local-seo-version-change branch September 13, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant