Fix stacking of inferred schema constraints #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We infer the schema constraints (currently only length and patterns) based on the meta-model. We do not inherit them by default since we usually generate the invariants for each class in the schema *separately* and let the schema engine deal with the inheritance. However, in the case of test data generation, it would be helpful if the schema constraints are properly inherited among the classes. In this patch, we re-structure the code and the tests to cater for that use case and extend the logic with an additional function to stack the schema constraints by the class ontology. Unsurprisingly, a couple of bugs were discovered and fixed along the re-structuring.
mristin
added a commit
that referenced
this pull request
May 24, 2022
* Verify the limitedness of type annotations (#156) * Allow for subclass checks in intermediate (#164) * Make stringify output multi-line string (#165) * Fix stacking of inferred schema constraints (#166) * Fix methods ignored in intermediate (#167) * Allow contracts for impl.-specific methods (#168) * Introduce ``specified_for`` for methods (#170) * Re-visit inheritance of methods and signatures (#171) * Add experimental support for ``any`` in invariants (#173) C# -- * Implement a practical set of visitors in C# (#151) * Allow null enums in C# stringification (#152) * Remove unused arguments in C# jsonization (#153) * Specify more implementation keys in C# jsonization (#154) * Fix documentation about classes in C# jsonization (#155) * Write xmlization for C# (#157) * Fix unspecified indention in C# (#161) * Fix indention in snippets of C# jsonization (#162) * Expect C# snippets for types in a directory (#169) RDF+SHACL --------- * Adapt RDF and SHACL to match aas-specs V3RC02 (#159)
Merged
mristin
added a commit
that referenced
this pull request
May 24, 2022
* Verify the limitedness of type annotations (#156) * Allow for subclass checks in intermediate (#164) * Make stringify output multi-line string (#165) * Fix stacking of inferred schema constraints (#166) * Fix methods ignored in intermediate (#167) * Allow contracts for impl.-specific methods (#168) * Introduce ``specified_for`` for methods (#170) * Re-visit inheritance of methods and signatures (#171) * Add experimental support for ``any`` in invariants (#173) C# -- * Implement a practical set of visitors in C# (#151) * Allow null enums in C# stringification (#152) * Remove unused arguments in C# jsonization (#153) * Specify more implementation keys in C# jsonization (#154) * Fix documentation about classes in C# jsonization (#155) * Write xmlization for C# (#157) * Fix unspecified indention in C# (#161) * Fix indention in snippets of C# jsonization (#162) * Expect C# snippets for types in a directory (#169) RDF+SHACL --------- * Adapt RDF and SHACL to match aas-specs V3RC02 (#159)
mristin
added a commit
that referenced
this pull request
May 24, 2022
* Verify the limitedness of type annotations (#156) * Allow for subclass checks in intermediate (#164) * Make stringify output multi-line string (#165) * Fix stacking of inferred schema constraints (#166) * Fix methods ignored in intermediate (#167) * Allow contracts for impl.-specific methods (#168) * Introduce ``specified_for`` for methods (#170) * Re-visit inheritance of methods and signatures (#171) * Add experimental support for ``any`` in invariants (#173) C# -- * Implement a practical set of visitors in C# (#151) * Allow null enums in C# stringification (#152) * Remove unused arguments in C# jsonization (#153) * Specify more implementation keys in C# jsonization (#154) * Fix documentation about classes in C# jsonization (#155) * Write xmlization for C# (#157) * Fix unspecified indention in C# (#161) * Fix indention in snippets of C# jsonization (#162) * Expect C# snippets for types in a directory (#169) RDF+SHACL --------- * Adapt RDF and SHACL to match aas-specs V3RC02 (#159)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We infer the schema constraints (currently only length and patterns)
based on the meta-model. We do not inherit them by default since we
usually generate the invariants for each class in the schema
separately and let the schema engine deal with the inheritance.
However, in the case of test data generation, it would be helpful if the
schema constraints are properly inherited among the classes.
In this patch, we re-structure the code and the tests to cater for that
use case and extend the logic with an additional function to stack the
schema constraints by the class ontology.
Unsurprisingly, a couple of bugs were discovered and fixed along
the re-structuring.