Move requirements-dev back to setup.py
#175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have to undo #160 since it actually broke the packaging. The issue went unnoticed as we haven't installed the new version from pypi.org recently. Specifically, we would have to package ``requirements-dev.txt`` with the package so that ``setup.py`` can read it on installation. It makes little sense to package development requirements for installation, though.
mristin
added a commit
that referenced
this pull request
May 24, 2022
* Move ``requirements-dev`` back to ``setup.py`` (#175)
Merged
mristin
added a commit
that referenced
this pull request
May 24, 2022
* Move ``requirements-dev`` back to ``setup.py`` (#175)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to undo #160 since it actually broke the packaging. The issue
went unnoticed as we haven't installed the new version from pypi.org
recently.
Specifically, we would have to package
requirements-dev.txtwith thepackage so that
setup.pycan read it on installation. It makeslittle sense to package development requirements for installation,
though.