Exclude external classes stringify assertions #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We modify the assertions in the ``stringify`` module to exclude classes coming from outside of the ``_types`` module. This is not only more efficient, but also makes the debugging easier.
mristin
deleted the
mristin/Exclude-classes-outside-module-in-stringify-assertions
branch
mristin
added a commit
that referenced
this pull request
Jun 19, 2022
* Adapt and re-record for aas-core-meta 2022.6.19 (#192) * Infer non-nullness in the intermediate (#186) * Fix duplicate inheritance of pattern constraints (#185) * Exclude external classes stringify assertions (#181) C# -- * Make C# classes with children implement interfaces (#190) * Allow classes without constructor arguments in C# (#189) * Fix C# generation for CodeInspect and testgen (#187) * Fix UTF-32 regexes for C# UTF-16-only engine (#183) * Relax constraints on C# namespace identifiers (#182)
Merged
mristin
added a commit
that referenced
this pull request
Jun 19, 2022
* Adapt and re-record for aas-core-meta 2022.6.19 (#192) * Infer non-nullness in the intermediate (#186) * Fix duplicate inheritance of pattern constraints (#185) * Exclude external classes stringify assertions (#181) C# -- * Make C# classes with children implement interfaces (#190) * Allow classes without constructor arguments in C# (#189) * Fix C# generation for CodeInspect and testgen (#187) * Fix UTF-32 regexes for C# UTF-16-only engine (#183) * Relax constraints on C# namespace identifiers (#182)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We modify the assertions in the
stringifymodule to exclude classescoming from outside of the
_typesmodule. This is not only moreefficient, but also makes the debugging easier.