-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: rename FromFile and File to FromRawBody and RawBody #117
Conversation
@danielkza let me know what you think 😃 |
Codecov Report
@@ Coverage Diff @@
## main #117 +/- ##
=======================================
Coverage 98.34% 98.35%
=======================================
Files 123 128 +5
Lines 4224 4247 +23
Branches 509 509
=======================================
+ Hits 4154 4177 +23
Misses 35 35
Partials 35 35
|
from xpresso.typing import Annotated | ||
|
||
|
||
class WebhookBody(BaseModel): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch
@adriangb any way to keep an alias from the previous name? just to surprise people a little less :) |
Yeah I can do that. Since this is a <1 library that is largely experimental I've generally taken the approach of favoring breaking changes over more code / shims, but this one should be easy enough. |
This is a breaking change that renames a couple symbols to disambiguate their usage.