Impact
Ledger crash. A user is able to initialize a post-genesis validator with a negative commission rate using the --force flag. If this validator gets into the consensus set, then when computing PoS inflation inside fn update_rewards_products_and_mint_inflation, an instance of mul_floor will cause the return of an Err, which causes finalize_block to error.
Patches
This issue has been patched in apps version 1.1.0. The PoS validity predicate now enforces that the commission rate is not negative and any transaction that fails the check will be rejected, both for newly initialized validators and for commission rate change of an existing validator.
Workarounds
There are no workarounds and users are advised to upgrade.
References
Impact
Ledger crash. A user is able to initialize a post-genesis validator with a negative commission rate using the
--forceflag. If this validator gets into the consensus set, then when computing PoS inflation insidefn update_rewards_products_and_mint_inflation, an instance ofmul_floorwill cause the return of anErr, which causesfinalize_blockto error.Patches
This issue has been patched in apps version 1.1.0. The PoS validity predicate now enforces that the commission rate is not negative and any transaction that fails the check will be rejected, both for newly initialized validators and for commission rate change of an existing validator.
Workarounds
There are no workarounds and users are advised to upgrade.
References