Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some deprecated and currently not working "Hgging Face" bots #973

Conversation

PeterDaveHello
Copy link
Collaborator

@PeterDaveHello PeterDaveHello commented Feb 5, 2025

This is something like #970 & #971. We should remove those old and unworking bots from the platform that we're currently not actively maintaining until something changes.

Summary by CodeRabbit

  • Chores
    • Streamlined chatbot options by removing several deprecated chatbots.
    • Updated the settings interface to reflect the reduced chatbot lineup, providing users a simpler, more focused selection experience.

Copy link
Contributor

coderabbitai bot commented Feb 5, 2025

Walkthrough

This change removes multiple bot implementations and their associated settings from the codebase. Several files under the src/bots/huggingface/ directory defining bot classes have been deleted, effectively eliminating their metadata, instantiation logic, and endpoint handling. Corresponding updates in src/bots/index.js have been made to remove imports, instances, and configuration tags. Additionally, the Vue component and settings entry for the Falcon 180b bot have been removed from the settings modal.

Changes

File(s) Change Summary
src/bots/huggingface/CodeLlamaHCBot.js, src/bots/huggingface/Falcon180bBot.js, src/bots/huggingface/FalconHC180bBot.js,
src/bots/huggingface/Llama2HC70bBot.js, src/bots/huggingface/Zephyr7bBot.js
Removed bot class implementations along with their metadata and instantiation logic.
src/bots/index.js Removed bot import statements, instances, and references from disabled arrays and botTags to reflect the deleted bot implementations.
src/components/BotSettings/Falcon180bBotSettings.vue Removed Vue component specific to Falcon 180b bot settings.
src/components/SettingsModal.vue Removed the import and settings entry for the Falcon 180b bot from the settings modal.

Sequence Diagram(s):

Poem

In the code forest, I hop with delight,
Trimming old branches in the pale moonlight.
Bots have vanished on a breezy day,
Clearing the path for a fresher way.
With every removed line, new dreams take flight—
A rabbit’s cheer in code so bright! 🐰

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8151906 and 2052100.

⛔ Files ignored due to path filters (5)
  • public/bots/codellama-hc-logo.png is excluded by !**/*.png
  • public/bots/falcon-180b-hc-logo.png is excluded by !**/*.png
  • public/bots/falcon-180b-logo.jpeg is excluded by !**/*.jpeg
  • public/bots/llama-huggingchat-logo.png is excluded by !**/*.png
  • public/bots/zephyr-7b-logo.png is excluded by !**/*.png
📒 Files selected for processing (8)
  • src/bots/huggingface/CodeLlamaHCBot.js (0 hunks)
  • src/bots/huggingface/Falcon180bBot.js (0 hunks)
  • src/bots/huggingface/FalconHC180bBot.js (0 hunks)
  • src/bots/huggingface/Llama2HC70bBot.js (0 hunks)
  • src/bots/huggingface/Zephyr7bBot.js (0 hunks)
  • src/bots/index.js (1 hunks)
  • src/components/BotSettings/Falcon180bBotSettings.vue (0 hunks)
  • src/components/SettingsModal.vue (0 hunks)
💤 Files with no reviewable changes (7)
  • src/bots/huggingface/Llama2HC70bBot.js
  • src/bots/huggingface/CodeLlamaHCBot.js
  • src/components/SettingsModal.vue
  • src/components/BotSettings/Falcon180bBotSettings.vue
  • src/bots/huggingface/Falcon180bBot.js
  • src/bots/huggingface/FalconHC180bBot.js
  • src/bots/huggingface/Zephyr7bBot.js
🔇 Additional comments (4)
src/bots/index.js (4)

1-59: LGTM! Import statements are consistent with bot removals.

The import statements correctly reflect the removal of deprecated Hugging Face bots while maintaining other necessary imports.


60-117: LGTM! Bot instances array is consistent with removals.

The all array correctly excludes instances of the removed bots while maintaining other bot instances.


119-119: LGTM! Disabled bots array is correctly updated.

The disabled array now only includes HuggingChatBot, which is consistent with the removal of other Hugging Face bots.


137-217: LGTM! Bot tags are consistent with removals.

The botTags object correctly maintains categorization without references to the removed bots.

Let's verify that all removed bots are completely cleaned up from the codebase:

✅ Verification successful

🏁 Script executed:

#!/bin/bash
# Description: Verify that removed bot files and references are completely cleaned up.

# Test: Search for any remaining references to removed bots
echo "Searching for references to removed bots..."
rg -i "Llama2HC70b|Falcon180b|FalconHC180b|CodeLlamaHC|Zephyr7b"

# Test: Check if any removed bot files still exist
echo "Checking for removed bot files..."
fd -t f "(Llama2HC70b|Falcon180b|FalconHC180b|CodeLlamaHC|Zephyr7b)" src/bots/huggingface/

Length of output: 333


Verification Successful: All removed bot references have been completely cleaned up.

  • No references to "Llama2HC70b", "Falcon180b", "FalconHC180b", "CodeLlamaHC", or "Zephyr7b" are present in the codebase.
  • No files matching the removed bot names exist in the src/bots/huggingface/ directory.
✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 10 out of 13 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • src/bots/huggingface/CodeLlamaHCBot.js: Evaluated as low risk
  • src/bots/huggingface/Falcon180bBot.js: Evaluated as low risk
  • src/bots/huggingface/FalconHC180bBot.js: Evaluated as low risk
@PeterDaveHello PeterDaveHello merged commit 85641c2 into ai-shifu:main Feb 13, 2025
1 check passed
@PeterDaveHello PeterDaveHello deleted the RemoveSomeDeprecatedHuggingFaceBots branch February 13, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant