Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gauge): add custom text tooltip support for gauge chart #6533

Merged
merged 1 commit into from
Dec 4, 2024
Merged

feat(gauge): add custom text tooltip support for gauge chart #6533

merged 1 commit into from
Dec 4, 2024

Conversation

BQXBQX
Copy link
Contributor

@BQXBQX BQXBQX commented Dec 4, 2024

Checklist
  • npm test passes
image
  • commit message follows commit guidelines
Description of change
  • Add gauge-custom-text-tooltip.ts test case
  • Update gauge mark to support text tooltip configuration
  • Remove default tooltip from DEFAULT_TEXT_OPTIONS
  • Extract tooltip from textStyle in gauge mark

@BQXBQX
feat(gauge): add custom text tooltip support for gauge chart
38ceb6e 
- Add gauge-custom-text-tooltip.ts test case
- Update gauge mark to support text tooltip configuration
- Remove default tooltip from DEFAULT_TEXT_OPTIONS
- Extract tooltip from textStyle in gauge mark
@BQXBQX
Copy link
Contributor Author

BQXBQX commented Dec 4, 2024 •
edited by hustcc
Loading

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12153528364

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.66%
Totals Coverage Status
Change from base Build 12151247231: 0.0%
Covered Lines: 10610
Relevant Lines: 11865
💛 - Coveralls

@hustcc hustcc merged commit 9e57dfe into antvis:v5 Dec 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BQXBQX @coveralls @hustcc