Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMEL-21710 camel-jbang-plugin-kubernetes - automatic cluster detection #17216

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

claudio4j
Copy link
Contributor

Set parameters when connected to specific cluster
https://issues.apache.org/jira/browse/CAMEL-21710

Description

Target

  • I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

Set parameters when connected to specific cluster
@claudio4j
Copy link
Contributor Author

As there are other cluster types like "kind", minikube with podman and many other flavors, if there are enough interest, they can be supported too.

Copy link
Contributor

@gansheer gansheer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if the delete command should also have this automatic detection. In case of Openshift we have to add the cluster-type parameter for the delete to work correctly (see documentation https://camel.apache.org/manual/camel-jbang-kubernetes.html#_delete_deployments). I think it would make sense to have the same if we apply a cluster-type automatically on run command we do the same on delete command.
WDYT ?

@claudio4j
Copy link
Contributor Author

I looked at the delete command, which I think should be redesigned, see discussion on zulip.

@gansheer
Copy link
Contributor

I looked at the delete command, which I think should be redesigned, see discussion on zulip.

Ok, then adding a warning about the auto detection on delete command in the doc will do for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants