[Refactor][Load]Unify common part in streamLoad and loadingTask planner #19118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/load
sollhui
changed the title
yiguolei
reviewed
Apr 27, 2023
|
|
||
| protected DescriptorTable descTable; | ||
|
|
||
| public void preparePlan(List<List<TBrokerFileStatus>> fileStatusesList, int filesAdded) { |
There was a problem hiding this comment.
If we use insert into select to replace current stream load logic, this planner maybe useless....
There was a problem hiding this comment.
Sorry,I don't quite understand the meaning of your comment in this line. I think the streamloadplanner won't call the prepareplan method, it's just abstracted out to unify the plan method.old is plan(TUniqueId loadId, List<List> fileStatusesList, int filesAdded),now plan(TUniqueId loadId),the purpose of this pr is only to unify common part in streamLoad and loadingTask planner,there is no logical modification.
|
run p0 |
|
run buildall |
fe/fe-core/src/main/java/org/apache/doris/planner/external/LoadPlanner.java
Show resolved
Hide resolved
|
run buildall |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: #18476
Please only focus on streamLoadPlanner LoadingTaskPlanner and LoadPlanner