[fix](nereids) fix push down non-foldable filter through project #47989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run buildall |
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 31468 ms |
morrySnow
reviewed
Feb 18, 2025
Comment on lines
63
to
70
| // Forbidden filter-project, we must make filter-project -> project-filter. | ||
| // except that the project contains NoneMovableFunction | ||
| if (child instanceof PhysicalProject && !((PhysicalProject<?>) child).containsNoneMovableFunction()) { | ||
| if (child instanceof PhysicalProject && !((PhysicalProject<?>) child).containsNoneMovableFunction() | ||
| && filter.getInputSlots().stream().map(((PhysicalProject<?>) child).getAliasToProducer()::get) | ||
| .noneMatch(expr -> expr != null && expr.containsNonfoldable())) { | ||
| throw new AnalysisException( | ||
| "Nereids generate a filter-project plan, but backend not support:\n" + filter.treeString()); | ||
| } |
There was a problem hiding this comment.
i think we could remove this if statement directly, because we have processed filter-project in translator
There was a problem hiding this comment.
i think we could remove this if statement directly, because we have processed filter-project in translator
had remove
TPC-DS: Total hot run time: 190016 ms |
ClickBench: Total hot run time: 30.51 s |
|
run buildall |
|
run buildall |
1 similar comment
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 31871 ms |
TPC-DS: Total hot run time: 189612 ms |
ClickBench: Total hot run time: 30.3 s |
|
run buildall |
TPC-H: Total hot run time: 31891 ms |
TPC-DS: Total hot run time: 183454 ms |
ClickBench: Total hot run time: 30.42 s |
morrySnow
approved these changes
Feb 19, 2025
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
|
PR approved by anyone and no changes requested. |
starocean999
approved these changes
Feb 19, 2025
This was referenced Feb 19, 2025
lzyy2024
pushed a commit
to lzyy2024/doris
that referenced
this pull request
Feb 21, 2025
…che#47989) When the expression contains slots which is an alias and its original expression is non-foldable, then this expression cann't push down through project. For example: ```filter(b > 1) -> project(a + random(1, 10) as b)```, if push down , it will got ```project(a + random(1, 10) as b) -> filter(a + random(1, 10) > 1)```, it will contains two distinct RANDOM function. This is an error. But if the filter expression itself contains non-foldable expression, it can still push down. For example: ```filter(a + random(1, 10) > 1) -> project(a)```, it can still push down the filter, and got ```project(a) -> filter(a + random(1, 10) > 1)```.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When the expression contains slots which is an alias and its original expression is non-foldable, then this expression cann't push down through project. For example:
filter(b > 1) -> project(a + random(1, 10) as b),if push down , it will got
project(a + random(1, 10) as b) -> filter(a + random(1, 10) > 1),it will contains two distinct RANDOM function. This is an error.
But if the filter expression itself contains non-foldable expression, it can still push down. For example:
filter(a + random(1, 10) > 1) -> project(a),it can still push down the filter, and got
project(a) -> filter(a + random(1, 10) > 1).Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)