commit：fix the front-end popup cannot exit #1957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tomsun28 <[email protected]>
|
@tomsun28 麻烦看下这个pr合并问题 |
tomsun28
reviewed
May 11, 2024
| if (account == null || account.getPassword() == null) { | ||
| return ResponseEntity.ok(Message.fail(MONITOR_LOGIN_FAILED_CODE, "Incorrect Account or Password")); | ||
| } else { | ||
| String password = loginDto.getCredential(); | ||
| String password = loginDto.getCredential().trim(); |
There was a problem hiding this comment.
hi, here we not suggest use the trim(), we donot need to update the username password the user input.
StringUtils.isBlank is no need, because the @Valid LoginDto has the vaild rule.
tomsun28
reviewed
May 11, 2024
| @@ -710,6 +710,9 @@ export class AlertSettingComponent implements OnInit { | |||
| onConnectModalCancel() { | |||
| this.isConnectModalVisible = false; | |||
| } | |||
| handleCancel() { | |||
There was a problem hiding this comment.
suggest update the method name more understand like other, eg: onExportTypeModalCancel()
|
The frontend ci error is due this, or you can run local |
# Conflicts: # web-app/src/app/routes/alert/alert-setting/alert-setting.component.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.