[HUDI-9040] Set the correct table path when renaming tables #12848
+38
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danny0405
approved these changes
Feb 18, 2025
danny0405
reviewed
Feb 18, 2025
...-common/src/main/scala/org/apache/spark/sql/hudi/command/AlterHoodieTableRenameCommand.scala
Show resolved
Hide resolved
CTTY
force-pushed
the
ctty/9040-rename
branch
from
bf455ed to
5dbee0c
Compare
yihua
reviewed
Feb 22, 2025
...park-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/ddl/TestAlterTable.scala
Outdated
Show resolved
Hide resolved
| @@ -52,8 +52,7 @@ case class AlterHoodieTableRenameCommand( | |||
| // update table properties path in every op | |||
| if (hoodieCatalogTable.table.properties.contains("path")) { | |||
| val catalogTable = sparkSession.sessionState.catalog.getTableMetadata(newName) | |||
| val path = catalogTable.storage.locationUri.get.getPath | |||
| AlterTableSetPropertiesCommand(newName, Map("path" -> path), isView).run(sparkSession) | |||
| AlterTableSetPropertiesCommand(newName, Map("path" -> catalogTable.location.toString), isView).run(sparkSession) | |||
There was a problem hiding this comment.
Does the base path of Hudi table change under the hood?
There was a problem hiding this comment.
i.e., all files are moved to the new path?
There was a problem hiding this comment.
No, data files will not be relocated. The issue happened because how we set the path in AlterHoodieTableRenameCommand may strip the scheme and authority of path in some cases.
CTTY
commented
Feb 23, 2025
| assertResult(true)( | ||
| newLocation2Path.equals(oldLocation2Path) | ||
| oldLocation2.get.equals(newLocation2.get) |
There was a problem hiding this comment.
This is the key change in test, we want to ensure the path won't change even with the scheme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Instead of using
catalogTable.storage.locationUri.get.getPaththat could remove scheme and authority, simply usecatalogTable.locationinstead when resetting table path in rename command.Impact
none
Risk level (write none, low medium or high below)
low
Documentation Update
none
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist