HDDS-12150. Abnormal container states should not crash the SCM ContainerReportHandler thread #7882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nerReportHandler thread
Comment on lines
309
to
+314
| logger.info("Moving container {} to CLOSED state, datanode {} " + | ||
| "reported CLOSED replica with index {}.", containerId, datanode, | ||
| replica.getReplicaIndex()); | ||
| if (!verifyBcsId(replica.getBlockCommitSequenceId(), container.getSequenceId(), datanode, containerId)) { | ||
| return true; // ignored = true | ||
| } |
There was a problem hiding this comment.
logger.info should come after verifyBcsId.
Comment on lines
+381
to
+389
| * Helper method to verify that the replica's bcsId matches the container's in SCM. | ||
| * Throws IOException if the bcsIds do not match. | ||
| * <p> | ||
| * @param replicaBcsId Replica bcsId | ||
| * @param containerBcsId Container bcsId in SCM | ||
| * @param datanode DatanodeDetails for logging | ||
| * @param containerId ContainerID for logging | ||
| * @return true if verification has passed, false otherwise | ||
| * @throws IOException Thrown when bcsIds do not match |
There was a problem hiding this comment.
The method doesn't throw IOException if the bcsIds do not match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Ignore (and log) the abnormal container (with lower BCSID) reported by a datanode in order to not crash the
ContainerReportHandlerthread.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-12150
How was this patch tested?
testQuasiClosedToClosedAttemptWithMismatchingBCSIDinTestContainerReportHandlertestClosingToQuasiClosedWithMismatchingBCSIDinTestContainerReportHandlerTestIncrementalContainerReportHandler?