[refurb] Correctly handle lengths of literal strings in slice-to-remove-prefix-or-suffix (FURB188)
#16237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AlexWaygood
approved these changes
Feb 18, 2025
dcreager
added a commit
that referenced
this pull request
Feb 19, 2025
* main: [red-knot] Allow any `Ranged` argument for `report_lint` and `report_diagnostic` (#16252) [pycodestyle] Exempt `site.addsitedir(...)` calls (E402) (#16251) red_knot_python_semantic: improve diagnostic message for "invalid argument type" ruff_db: add "secondary" messages to `Diagnostic` trait ruff_db: refactor snippet rendering red_knot_python_semantic: remove `Ranged` impl for `TypeCheckDiagnostic` [red-knot] Refactor `infer_chained_boolean_types` to have access to `TypeInferenceBuilder` (#16222) Add `red_knot/README.md` (#16230) [airflow] move class attributed related cases to AIR302_class_attribute (AIR302) (#16226) [red-knot] Update tests for attributes inferred from parameters (#16208) [red-knot] update TODO comment in mdtest (#16242) [`refurb`] Correctly handle lengths of literal strings in `slice-to-remove-prefix-or-suffix` (`FURB188`) (#16237) Pass `ast::PythonVersion` to `type_hint_resolves_to_any` (#16236) Use `ast::PythonVersion` internally in the formatter and linter (#16170) Add `SECURITY.md` (#16224)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes false negative when slice bound uses length of string literal.
We were meant to check the following, for example. Given:
We want to know whether:
suffixis a string literal andboundis a number literalsuffixis an expression andboundisexactly
-len(suffix)(as AST nodes, prior to evaluation.)The issue is that negative number literals like
-10are stored as unary operators applied to a number literal in the AST. So whensuffixwas a string literal butboundwas-len(suffix)we were getting caught in the match arm whereboundneeded to be a number. This is now fixed with a guard.Closes #16231