Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dockerfile #121

Merged
merged 6 commits into from
Jan 11, 2023
Merged

Update dockerfile #121

merged 6 commits into from
Jan 11, 2023

Conversation

sajith
Copy link
Member

@sajith sajith commented Jan 11, 2023

Issue is #120.

sajith added 6 commits January 11, 2023 10:11
@sajith
Use older pce API
a72d127
@sajith
Do not install ortools separately
5b1c938 
ortools is a pce requirement since pce commit
f1cd2d8de5b9fe409d3e4d9e5d3cc51e2e495d79
@sajith
Do not install grenml
5045e51 
grenml is a datamodel requirement since datamodel commit
f1cd2d8de5b9fe409d3e4d9e5d3cc51e2e495d79
@sajith
Use a tagged version of datamodel
599e638
@sajith
Do not install pce and datamodel separately in Dockerfile
6163bd7 
They are already in requirements.txt
@sajith
Install python3-dev in Dockerfile
ec81d0e 
python-dev is a metapackage that will install a whole bunch of
Python 2 packages that we don't need.
@sajith sajith requested a review from congwang09 January 11, 2023 16:43
@sajith sajith self-assigned this Jan 11, 2023
@sajith sajith linked an issue Jan 11, 2023 that may be closed by this pull request
Unbreak the Dockerfile #120
Closed
@sajith sajith marked this pull request as ready for review January 11, 2023 16:45
congwang09
congwang09 approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@congwang09 congwang09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@sajith sajith merged commit d9faa04 into main Jan 11, 2023
@sajith sajith deleted the 120.update-dockerfile branch January 11, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congwang09 congwang09 congwang09 approved these changes

Assignees

@sajith sajith

Labels
ci/cd epic_ci/cd epic_sdx_controller
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unbreak the Dockerfile
2 participants
@sajith @congwang09