Fix min and max length for iso3166_2_lvl4 attribute #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this related to the new "community" attribute for the Port? |
Pull Request Test Coverage Report for Build 13331873826Details
💛 - Coveralls |
Hi Yufeng. It is not. It is related to the |
YufengXin
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #165
Description of the change
According to the Topology data model spec, the iso3166_2_lvl4 should be composed by a 2 alphanumeric characters representing the country code + "-" + up to three alpha chars obtained from national sources and stems from coding systems already in use in the country concerned. The regex code for this attribute was correct, but the min and max length were not comply with the spec.
This PR fixes the min and max length for the iso3166_2_lvl4 attribute.