-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
991 gps path follow #1046
991 gps path follow #1046
Conversation
- logger to log arbitrary memory properties - pipe allows renaming of memory properties - serial_port.py reads lines from a serial port and puts then in named memory properties for use by other parts. This makes it easier to write a part and unit test the part by separating our the serial port. It also makes the serial port code reusable. - text_writer.py will write data to CSV/TSV files
- gps.py now uses serial_part.py to read from serial port, so it does not need to know about the specifics of how it gets an nmea sentence. - path now allows saving as either a Rosbag or a delimited test file, like a CSV or a TSV.
- uses the add_**** methods in complete.py to add camera, controller, drivetrain, odometry, etc. so it supports that same hardware as the complete.py template. - adds gps line following. - a large change to the user flow to make it more like the complete.py network, where there is a 'user' mode to save waypoints and an 'autopilot' mode to drive autonomously.
I have empirically tested the TCIII |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI tests need to pass. Otherwise, looks good to me, only minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Issue 991
This is been cherry picked from 921-gps-logger branch, which was successfully used in the Sept. 2022 Fremont outdoor race. See Ezward on GPS for a complete description of how the car and software were setup to use this branch.