Migrate to smithy 1.7 and generate APIGateway service #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skotambkar
requested review from
jasdel and
skmcgrail
and removed request for
jasdel
skotambkar
changed the title
jasdel
approved these changes
May 5, 2021
| @@ -71,7 +71,9 @@ smithy-go-publish-local: | |||
|
|
|||
| gen-config-asserts: | |||
| @echo "Generating SDK config package implementor assertions" | |||
| cd config && go generate | |||
| cd config \ | |||
| && go mod tidy \ | |||
There was a problem hiding this comment.
does mod tidy need to be mixed into these tasks? mod tidy has a separate task that will be run by make generate.
There was a problem hiding this comment.
We have to run go mod tidy, when we cd into Config. Or we get an error related to go sum entry not found.
There was a problem hiding this comment.
Ah i see, could also set GOFLAGS=-mod=mod here as well potentially instead of running mod tidy.
jrichard8
pushed a commit
to jrichard8/aws-sdk-go-v2
that referenced
this pull request
Feb 14, 2022
* update codegen to use updated smithy provider constructor * add apigateway model * generate apigateway client * update codegen to use renamed shape names. * generate new protocol test * regenerate apigateway service * update to depend on new smithy go hash * update codegen to use renamed shape name in case of conflict * add go mod tidy step in gen-config-asserts * update go mod,go sum for protocol tests and apigateway service * minor comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on aws/smithy-go#289
Generates latest APIGateway model
Updates codegen to use rename pattern i.e. shapeId.getName(service) when retrieving shape name
TODO:
[ x ] generate and validate protocol tests