Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated method: this method is going to be deleted. Use Fluent::MessagePackFactory.msgpack_unpacker #194

Closed
liorco3000 opened this issue Jan 30, 2020 · 7 comments

Comments

@liorco3000
Copy link

liorco3000 commented Jan 30, 2020

Problem
We see hundreds of deprecation warnings per minute:

fuentd-agent-v2-jh5tn fluentd-agent 2020-01-30 12:18:59 +0000 [warn]: #0 Deprecated method: this method is going to be deleted. Use Fluent::MessagePackFactory.msgpack_unpacker

So i guess it related to this plugin we added recently.
Any fix for this ?

@mindw
Copy link

mindw commented Jan 30, 2020

@eredi93
Copy link

eredi93 commented Feb 3, 2020

I'm also getting this warning. @simukappu is it as simple as preparing a PR like the one @mindw shared in the comment above?

@simukappu
Copy link
Contributor

Hi,
Thank you for your feedback. Which version of Fluentd are you using?
The class method Fluent::MessagePackFactory.msgpack_unpacker was added after Fluentd v1.8 here. Deprecated log was also added here with this. However, the latest td-agent v3.5.1 includes Fluentd v1.7.4.
We would appreciate it if you could give us more feedback. Thanks!

@eredi93
Copy link

eredi93 commented Feb 11, 2020

@simukappu I'm using the lastest version of fluentd 1.9.1
is the issue here the fact that it would break td-agent?
I'm just wondering if we could work on removing the deprecated message, but if it would break other standard deployments like td-agent then i'm happy to leave it as is until they upgrade the package to 1.8 or newer

@simukappu
Copy link
Contributor

Hi @eredi93,
Could you test this patch whether you can remove the deprecated messages?

$ git clone https://github.com/awslabs/aws-fluent-plugin-kinesis.git
$ cd aws-fluent-plugin-kinesis
$ git checkout issue-194
$ gem build fluent-plugin-kinesis.gemspec

$ td-agent-gem install fluent-plugin-kinesis-3.2.0.gem
# Or
$ fluent-gem install fluent-plugin-kinesis-3.2.0.gem

@eredi93
Copy link

eredi93 commented Feb 12, 2020

@simukappu i can confirm the deprecated messages are gone when using the patch 🙇

@simukappu
Copy link
Contributor

Released as v3.2.1. Thank you!
https://rubygems.org/gems/fluent-plugin-kinesis/versions/3.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants