Don't create too-long records from too-long records (leading to outage). #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this patch, a single too-long record causes an even longer record to be logged (which can cause the same error which logs an even longer record, eventually leading to a progression of insanely long records consuming available capacity and effectively halting nearly all other transfers).
|
Hi @TyeMcQueen , Thank you for this PR. I took your idea and created a new PR to solve this issue. #127 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch, a single too-long record causes an even longer record
to be logged (which can cause the same error which logs an even longer
record, eventually leading to a progression of insanely long records consuming
available capacity and effectively halting nearly all other transfers).