Don't chomp formatted messages. Fixes #142

[geofffranks]

Signed-off-by: David Bishop [email protected]

[burkaygur]

any chance we can prioritize this @riywo ?

[cynipe]

having the same trouble. is there any chance?

[fujiwara]

@riywo Please confirm this or consider to delegate to an active maintainer. 🙏

[riywo]

Sorry for our late response. The team is prioritizing this, so please add use cases when you need it.

@geofffranks , please comfirm the usage of this contribution by adding the statement from this template. https://github.com/awslabs/aws-fluent-plugin-kinesis/blob/master/.github/PULL_REQUEST_TEMPLATE.md

[geofffranks]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…

Sent from my iPhone

On Feb 4, 2019, at 12:37 PM, Ryosuke IWANAGA ***@***.***> wrote: Sorry for our late response. The team is prioritizing this, so please add use cases when you need it. @geofffranks , please comfirm the usage of this contribution by adding the statement from this template. https://github.com/awslabs/aws-fluent-plugin-kinesis/blob/master/.github/PULL_REQUEST_TEMPLATE.md — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[riywo]

@geofffranks Thank you for your confirming.

@fujiwara @cynipe @burkaygur in case you have not been notified, please post your use cases here for us to understand the issue properly. Probably we can use this issue for your feedback: #142

[fujiwara]

In my use case, I send records formatted by CSV formatter to Kinesis Streams.
Firehose saves into S3 from that streams.

I expect valid CSV, but the file has not "\n" for each line because plugin-kinesis removes "\n" at the tail of formatted records.

[cynipe]

same as @fujiwara. Actually, mine is json though.

[burkaygur]

Same use case as @cynipe.

[riywo]

Thank you for your use cases.

Just released v3.0.0.rc.2.0 which doesn't chomp by default. Please try it out and give us feedback! https://rubygems.org/gems/fluent-plugin-kinesis/versions/3.0.0.rc.2.0

[cynipe]

@riywo Just tried it out.
For me, v3.0.0.rc.2.0 works like a charm 🎉

[burkaygur]

Whats the timeline for 3.0.0 release @riywo ? Tried and works great.

[simukappu]

@burkaygur We will publish v3.0.0 next week unless we get any trouble feedback. We are appreciate your patience.

[simukappu]

This PR changes have been already merged into master branch as v3.0.0.rc.2.0. I will close this PR and let's move to #142.