Use msgpack each more naive impl #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gpack_each unpacking
Because formatted_to_msgpack_binary? is defined in Fluentd v0.14.15.
cosmo0920
force-pushed
the
use-msgpack_each-more-native-impl
branch
from
02c8ed4 to
8ae0954
Compare
cosmo0920
changed the title
simukappu
approved these changes
Oct 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
This PR follows up #156 to remove tricky msgpack unpacking code.
Description of changes:
Fluentd v0.14 series requests to define
formatted_to_msgpack_binary?method which returnstruewhen using msgpack chunk format.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.