Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process credentials #178

Merged
merged 1 commit into from
Apr 17, 2019
Merged

Process credentials #178

merged 1 commit into from
Apr 17, 2019

Conversation

tahoward
Copy link
Contributor

Description of changes:

Add a new config section to implement Aws::ProcessCredentials.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@riywo
Copy link
Contributor

riywo commented Apr 10, 2019

Hi,

Thank you for this PR. We are prioritizing now.

It is not mandatory, but do you have a chance to add unit tests like this? https://github.com/awslabs/aws-fluent-plugin-kinesis/blob/master/test/kinesis_helper/test_client.rb#L48-L62

@riywo
Copy link
Contributor

riywo commented Apr 10, 2019

Also, if possible, could you squash your commits to a single (or a few) commit(s)?

@riywo
Copy link
Contributor

riywo commented Apr 10, 2019

For maintainers: we should point this (or equivalent) link in README to describe danger of the feature. https://docs.aws.amazon.com/cli/latest/topic/config-vars.html#sourcing-credentials-from-external-processes

@riywo riywo added this to the v3.1.0 milestone Apr 10, 2019
@tahoward tahoward force-pushed the process_credentials branch 2 times, most recently from d860f38 to 0e82e7f Compare April 11, 2019 05:06
@tahoward
Copy link
Contributor Author

@riywo Thank you for looking into this! I have implemented suggested changes.

@riywo riywo requested review from simukappu and riywo April 12, 2019 22:52
riywo
riywo reviewed Apr 12, 2019
View reviewed changes
Copy link
Contributor

@riywo riywo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a small comment.

Thank you for adding unit tests!

simukappu
simukappu reviewed Apr 14, 2019
View reviewed changes
Copy link
Contributor

@simukappu simukappu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also added a small comment.
Thank you for your contribution!

@tahoward tahoward force-pushed the process_credentials branch 2 times, most recently from dc9006f to 12bb957 Compare April 15, 2019 18:27
simukappu
simukappu reviewed Apr 15, 2019
View reviewed changes
Copy link
Contributor

@simukappu simukappu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your quick response! I added one more small comment.

riywo
riywo reviewed Apr 16, 2019
View reviewed changes
Copy link
Contributor

@riywo riywo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added one more comment.

@tahoward
Update client.rb
ff6590c 
Add process_credentials config

Update client.rb

Add process_credentials config

Update README.md

Update README.md

Add unit test

Update readme

Add omission if aws-sdk-core version < 3.24.0

Make `process` attribute mandatory.

Make `process` attribute mandatory.

Add config error
@tahoward tahoward force-pushed the process_credentials branch from 12bb957 to ff6590c Compare April 17, 2019 05:47
@tahoward
Copy link
Contributor Author

Added suggested ConfigError for aws-sdk-core < 3.24.0

simukappu
simukappu approved these changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@simukappu simukappu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Preparing to merge. Thank you!

riywo
riywo approved these changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@riywo riywo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thank you for your contribution.

@riywo riywo merged commit 2bc9adf into awslabs:master Apr 17, 2019
@simukappu simukappu mentioned this pull request Apr 18, 2019
Merged
@riywo
Copy link
Contributor

riywo commented Apr 18, 2019

We've released v3.1.0 today. Thank you for your all contribution! https://rubygems.org/gems/fluent-plugin-kinesis/versions/3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riywo riywo riywo approved these changes

@simukappu simukappu simukappu approved these changes

Assignees

@simukappu simukappu

Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tahoward @riywo @simukappu