Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added configuration parameter to support non-default STS API Endpoint. #186

Merged
merged 3 commits into from
Oct 10, 2019

Conversation

sbruggeman
Copy link
Contributor

Added a configuration parameter to allow for the user to define a non-default STS API endpoint. This will allow users to specify regional or custom STS endpoints. Regional STS endpoint usage is required when interfacing with STS via a PrivateLink VPC endpoint.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@simukappu simukappu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Under checking process.

Copy link
Contributor

@simukappu simukappu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. I have added several comments to your changes. Can you check them?

…ogether.

reverted sts client to support only a region parameter.
@sbruggeman
Copy link
Contributor Author

Made the recommended changes in latest commit on this PR.

@simukappu
Copy link
Contributor

Under checking process. Please wait a moment until merged.

@hramc
Copy link

hramc commented Oct 9, 2019

Hi

Can you please review this PR and merge to master.
we need this fix to enable cross account logging in our application.

@simukappu
Copy link
Contributor

Checking process has been done. We will merge this PR. Sorry for waiting.

@simukappu simukappu merged commit a808203 into awslabs:master Oct 10, 2019
@simukappu simukappu added this to the v3.2.0 milestone Oct 10, 2019
@simukappu simukappu mentioned this pull request Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants