Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#203: add placeholder support to delivery_stream_name for kinesis_firehose. closes #203 #204

Merged
merged 2 commits into from
Jul 15, 2020

Conversation

clcpolevaulter
Copy link
Contributor

Issue #203

This is heavily based off the changes to #174. Placeholders are now supported in firehose streams.

⚠️ I won't claim to know the best way to test this but all the test do pass.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@clcpolevaulter
Copy link
Contributor Author

Any updates on this?

@clcpolevaulter
Copy link
Contributor Author

Any updates on this request?

Copy link
Contributor

@simukappu simukappu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you or your request! Could you add placeholders support to Firehose README?

@clcpolevaulter clcpolevaulter requested a review from simukappu July 12, 2020 21:16
@clcpolevaulter
Copy link
Contributor Author

@simukappu ::

I have updated the README as requested.

Copy link
Contributor

@simukappu simukappu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simukappu
Copy link
Contributor

Please wait a moment as we are going on the process.

@simukappu simukappu merged commit 1ed6535 into awslabs:master Jul 15, 2020
@simukappu
Copy link
Contributor

Merged and published as v3.2.3. Thank you for your contribution!
https://rubygems.org/gems/fluent-plugin-kinesis/versions/3.2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants