Implement web identity credentials for irsa #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a web_identity_credentials config section and handler for supporting IRSA. Thus, we can use identity file within EKS. Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
|
Hi, @simukappu ! |
|
Hi @cosmo0920, |
simukappu
approved these changes
Oct 31, 2020
|
Thank you for the patches! I planned to send the similar one but find this 👍 Do you know when this PR will be merged and release on https://rubygems.org? |
|
@cosmo0920 @takanabe Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#209
Description of changes:
We want to use IRSA credentials on this plugin like as fluent-plugin-s3.
I'd referred IRSA implementation on fluent-pugin-s3 but this project is licensed under Apache 2.0 license:
https://github.com/fluent/fluent-plugin-s3
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.