-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: consume smithy-kotlin SigV4a implementation #1536
base: main
Are you sure you want to change the base?
Conversation
A new generated diff is ready to view. |
This comment has been minimized.
This comment has been minimized.
A new generated diff is ready to view. |
A new generated diff is ready to view. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I renamed the file (fixing a typo) which causes this massive diff. See this commit for a more accurate view of the changes: de470e5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: I believe SESv2 supports SigV4a now. Can we un-@Ignore
this E2E test?
|
A new generated diff is ready to view. |
Nice, I think we can, re-enabled. |
Affected ArtifactsChanged in size
|
Upstream PR: smithy-lang/smithy-kotlin#1246
Issue #
Description of changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.