Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GIT PULL] github: Build all newly pushed commits #1352

Merged
merged 3 commits into from
Feb 20, 2025

Conversation

ammarfaizi2
Copy link
Contributor

Hi Jens,

Follow up of #1227

Please pull this GitHub action update to maintain bisectability. It
builds all newly pushed commits instead of only single HEAD commit.

After this one merged, please create a new branch next where you
first push your changes, make sure everything is build-tested and
spellchecked before fast-forward to master.

That way, we can keep master always in a good shape and next is
where you can test and rebase things before fast-forward to master.

The following changes since commit 66b071d1470ae787d47d4cb8d9cb3836249baf61:

  Merge branch 'gha-clang' of https://github.com/cmazakas/liburing (2025-02-19 09:05:36 -0700)

are available in the Git repository at:

  https://github.com/ammarfaizi2/liburing.git tags/gh-action-2025-02-20

for you to fetch changes up to 9aeebcd17b4993d1a70c19fd3fd837dbe821b303:

  github: Rename build.yml to ci.yml (2025-02-20 11:48:12 +0700)

----------------------------------------------------------------
GitHub action update from Ammar Faizi:

  To maintain bisectability, build all pushed commits instead of only
  single HEAD commit.

  Link: https://github.com/axboe/liburing/pull/1352
  Link: https://github.com/axboe/liburing/discussions/1227

----------------------------------------------------------------
Ammar Faizi (3):
      github: Build all newly pushed commits
      github: Combine Codespell and Shellcheck jobs into a single YAML file
      github: Rename build.yml to ci.yml

 .github/workflows/{build.yml => ci.yml} | 141 ++++++++++++++++++++++++++++++----------
 .github/workflows/codespell.yml         |  25 -------
 .github/workflows/shellcheck.yml        |  20 ------
 3 files changed, 107 insertions(+), 79 deletions(-)
 rename .github/workflows/{build.yml => ci.yml} (53%)
 delete mode 100644 .github/workflows/codespell.yml
 delete mode 100644 .github/workflows/shellcheck.yml

To maintain bisectability, build all pushed commits instead of only
single HEAD commit.

Link: axboe#1227
Signed-off-by: Ammar Faizi <[email protected]>
To eliminate redundancy in the get_commit_list job, the Shellcheck and
Codespell jobs have been merged into a single build YAML file.

Additionally, the workflow name has been updated to "CI" instead of
"Build test" to better reflect its expanded scope beyond just building.

Signed-off-by: Ammar Faizi <[email protected]>
Since the workflow now includes Codespell and Shellcheck in addition to
the build process, renaming it to ci.yml makes it more generic and
accurately reflects its purpose.

Signed-off-by: Ammar Faizi <[email protected]>
@axboe
Copy link
Owner

axboe commented Feb 20, 2025

This is great, thanks a lot for doing this work!

@axboe axboe merged commit 441d29d into axboe:master Feb 20, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants