[GIT PULL] Test fixes and compatibility with older kernels #1354
+25
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test() returns T_EXIT_{FAIL,PASS,SKIP}, but main() checks for a return
value of -1 to indicate failure. Ensure failures are reported by
checking the return value against T_EXIT_FAIL instead. Return
T_EXIT_FAIL from main() if any test failed, T_EXIT_SKIP if all were
skipped, and T_EXIT_PASS if any passed and none failed.
Remove the redundant if (no_connect) check in main(); test() already
returns T_EXIT_SKIP in that case.
Signed-off-by: Caleb Sander Mateos <[email protected]>
Older kernels don't support IORING_SETUP_SINGLE_ISSUER and IORING_SETUP_DEFER_TASKRUN, causing io_uring_setup() to return -EINVAL. Return T_EXIT_SKIP in this case like other tests do to avoid reporting failure. Also correct the name of the function in the failure line; "io_uring_queue_setup" is not a thing. Signed-off-by: Caleb Sander Mateos <[email protected]>
Older kernels don't support IORING_SETUP_SUBMIT_ALL, causing io_uring_setup() to return -EINVAL. Return T_EXIT_SKIP in this case like other tests do to avoid reporting failure. Signed-off-by: Caleb Sander Mateos <[email protected]>
Older kernels don't support IORING_SETUP_SINGLE_ISSUER or IORING_SETUP_DEFER_TASKRUN, causing io_uring_setup() to return -EINVAL. Return T_EXIT_SKIP in this case like other tests do to avoid reporting failure. Signed-off-by: Caleb Sander Mateos <[email protected]>
Older kernels don't support IORING_TIMEOUT_MULTISHOT, causing SQEs that set the flag to immediately post a CQE with res = -EINVAL. test_timeout_multishot() already checks for this and sets no_multishot, which causes most other IORING_TIMEOUT_MULTISHOT test cases to skip. However, test_update_multishot_timeouts() doesn't check no_multishot and fails on kernels without support. So add the check and skip that test case too if no_multishot is set. Catch the T_EXIT_SKIP return value in main() and continue running the other test cases. Signed-off-by: Caleb Sander Mateos <[email protected]>
Check that io_uring_queue_init_params() returns 0. Fail the test if not. Signed-off-by: Caleb Sander Mateos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some testing gaps where errors would not cause the tests to fail.
Also add some
-EINVALresult checks to allow tests to skip rather than fail on older kernels (tested on 5.15).git request-pull output:
By submitting this pull request, I acknowledge that: