Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor NestedMultisigBuilder to use NestedMultisigBase #119

Merged
merged 1 commit into from
Jan 30, 2025
Merged

chore: refactor NestedMultisigBuilder to use NestedMultisigBase #119

merged 1 commit into from
Jan 30, 2025

Conversation

jackchuma
Copy link
Contributor

No description provided.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 22, 2025 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@cb-heimdall
Copy link
Collaborator

Review Error for MrSaints @ 2025-01-30 16:29:29 UTC
User must have write permissions to review

@cb-heimdall
Copy link
Collaborator

Review Error for cbfyi @ 2025-01-30 16:35:43 UTC
User failed mfa authentication, public email is not set on your github profile. see go/mfa-help

@jackchuma jackchuma merged commit 4e22766 into main Jan 30, 2025
2 checks passed
@jackchuma jackchuma deleted the jack/refactor-nested-multisig-builder branch January 30, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrSaints MrSaints MrSaints approved these changes

@xenoliss xenoliss xenoliss approved these changes

@cbfyi cbfyi cbfyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jackchuma @cb-heimdall @MrSaints @xenoliss @cbfyi