Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick icon does not appear unless the parent service item also has an icon #874

Open
tanasegabriel opened this issue Feb 18, 2025 · 0 comments

Comments

@tanasegabriel
Copy link
Contributor

tanasegabriel commented Feb 18, 2025

Describe the bug
The recently introduced "quick" links do not surface their icons if the parent service item has no icon.

  - name: Dev Tools
    logo: https://cdn.jsdelivr.net/gh/homarr-labs/dashboard-icons/webp/terminal.webp
    items:
      - name: Grafana
        logo: https://cdn.jsdelivr.net/gh/homarr-labs/dashboard-icons/webp/grafana.webp
        url: https://grafana.<domain_redacted>/dashboards
        quick:
          - name: Test
            icon: fa-solid fa-chart-line
            url: https://1.1.1.1

Image

It seems there is a conditional around the item also having an icon (I use logos everywhere). If I simply add icon: true to the item:

  - name: Dev Tools
    logo: https://cdn.jsdelivr.net/gh/homarr-labs/dashboard-icons/webp/terminal.webp
    items:
      - name: Grafana
        logo: https://cdn.jsdelivr.net/gh/homarr-labs/dashboard-icons/webp/grafana.webp
        url: https://grafana.<domain_redacted>/dashboards
        icon: true
        quick:
          - name: Test
            icon: fa-solid fa-chart-line
            url: https://1.1.1.1

Image

But as you can see, that messes with the padding in this scenario.

Expected behavior
Quick icons should be present regardless of the configuration of the parent item. Tangentially, it seems the Ping custom service clashes with quick icons, as they cannot be used in this combination, but it is understandable if this is outside the scope of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant