Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cards): add multi link support #865

Merged
merged 1 commit into from
Feb 2, 2025
Merged

feat(cards): add multi link support #865

merged 1 commit into from
Feb 2, 2025

Conversation

bastienwirtz
Copy link
Owner

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

2025-02-02T15:38:43,628744466+01:00

Fixes #840

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've read & comply with the contributing guidelines
  • I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • I have made corresponding changes to the documentation (README.md).
  • I've checked my modifications for any breaking changes, especially in the config.yml file

@bastienwirtz bastienwirtz merged commit 3468b9d into main Feb 2, 2025
1 check passed
@bastienwirtz bastienwirtz deleted the multilink branch February 2, 2025 14:43
@grasshide
Copy link

I love this feature! However, the icon for the links do not show up.

Screenshot 2025-02-14 at 09 24 07
- name: "victron"
  logo: "assets/tools/victron.png"
  url: ""
  quick:
    - name: "gui-v1"
      url: "http://192.178.1.128/gui-v1/"
      icon: "fa-solid fa-arrow-up-right-from-square"
      target: "_blank"
    - name: "gui-v2"
      url: "http://192.178.1.128/gui-v2/"
      icon: "fa-solid fa-arrow-up-right-from-square"
      target: "_blank"

@bastienwirtz
Copy link
Owner Author

Thanks for your feedback @grasshide! I'll look into it asap!

@tanasegabriel
Copy link
Contributor

tanasegabriel commented Feb 17, 2025

Indeed, the quick icon does not appear unless the parent item also has an icon defined. I can make the icon appear if I set icon: true to the corresponding item, but that messes the padding of things, as all of my items make use of logos.

opened #874

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Multiple URLs per item
3 participants